search

DuendeSoftware / Samples

Samples for our Products
Other
227 stars 269 forks source link

Quickstarts use pages not mvc #41

Closed josephdecock closed 2 years ago

josephdecock commented 2 years ago

This updates the samples for quickstarts 2, 3 and 4 to use a pages based ui and remove the mvc dependency.

josephdecock commented 2 years ago

Hey @brockallen and @leastprivilege, this should be ready for review. I don't have permissions to request reviews in this repo, so just tagging you both here.

josephdecock commented 2 years ago

Odd - I created the web app from microsoft's template, and it uses an old version of jq validation that codeQL says is insecure. Trying the latest version now...

josephdecock commented 2 years ago

See also the corresponding update to the docs repo: https://github.com/DuendeSoftware/docs.duendesoftware.com/pull/92

josephdecock commented 2 years ago

Hmm, even the latest version of jq validation has the security flaw according to CodeQL. I'm just going to remove it entirely from the sample. We're not using it anyway.