Dueris / OriginsPaper

Custom Origins Plugin for PaperMC
https://modrinth.com/plugin/originspaper
Other
27 stars 6 forks source link

[BUG] - #46

Closed A53o closed 1 year ago

A53o commented 1 year ago

Describe the bug I'm getting an error on server startup

Plugin Version 0.2.1

Minecraft version 1.20.1

Server software Paper

Steps to reproduce start the server

What should happen? no errors and startup fine

What is happening instead? Error

Stacktrace/Errors on Console https://pastebin.com/c3tdFxX3

Dueris commented 1 year ago

Bro github doesn't support jar file types for upload....

Dueris commented 1 year ago

Hold on I'm getting a Wetransfer.com link lmfao

Dueris commented 1 year ago

https://we.tl/t-yUQVjs5Ovp Use that to download the updated plugin

A53o commented 1 year ago

ok im trying it now

A53o commented 1 year ago

https://spark.lucko.me/hCc95l16Yg

A53o commented 1 year ago

ok so the Enderian is still very laggy rip

Dueris commented 1 year ago

That improved things by 10%. Progress lol

A53o commented 1 year ago

lol is there a way for you to optimise that more it dose not mater how long it takes

Dueris commented 1 year ago

Probably yes, just unsure due to me having to check the renderer so often. I could lower the tps rate for that task, and I can maybe try a few other things to optimize it, but it will take some experimenting

A53o commented 1 year ago

yea its fine take your time i just need something that works and it dose not mater how long it takes

Dueris commented 1 year ago

According to the spark report it's coming from the conditioner code so imma check that out first one sec

A53o commented 1 year ago

ok

Dueris commented 1 year ago

Found whats causing the issue. I will try and create a better way of doing this, probably with pre-class loading methods

A53o commented 1 year ago

ok take your time i dont need it any time soon

Dueris commented 1 year ago

Alrighty, I may have an optimized build working by Sunday

Dueris commented 1 year ago

Mainly bc I am busy with stuff this week lol. Probably would be Saturday at most

A53o commented 1 year ago

ok cool get back to me when you have it

Dueris commented 1 year ago

testing something now

A53o commented 1 year ago

Ok sweet

Dueris commented 1 year ago

https://we.tl/t-7IYVcwQ5lMa

try that. idk how its doing bc my computer is using most of its cpu on other htings and its running so many things that is basically dying lol. also spark is broken bc the css is just gone lmfao

A53o commented 1 year ago

Alr I'll test it latter today

A53o commented 1 year ago

um the website is brokin Screenshot_20231029_124629

Dueris commented 1 year ago

lmao hold on

Dueris commented 1 year ago

https://we.tl/t-qCAo99tMRd

Dueris commented 1 year ago

new linky

A53o commented 1 year ago

ok

A53o commented 1 year ago

do i need to send a spark report

Dueris commented 1 year ago

if you want then yes, but if it clearly performs better than no. spark css also kinda bork toda lmfao

A53o commented 1 year ago

didn't work

Dueris commented 1 year ago

rip

Dueris commented 1 year ago

aight lemme continue tryin

A53o commented 1 year ago

also it just lags when i join without an origin

Dueris commented 1 year ago

mk

Dueris commented 1 year ago

it seems to happen this time when joining the 2 thread proccesses i setup. i will fix this one sec.

Dueris commented 1 year ago

i actually made it worse and my server just crashed lmao

Dueris commented 1 year ago

who knew optimization would be a pain

Dueris commented 1 year ago

oh damn i actually optimized that code a lot. its 214% faster now lol

Dueris commented 1 year ago

ok i can prob optimize this more but at this point its basically the renderer thats taking most of the cpu. but it is noticeably faster

Dueris commented 1 year ago

went from abt 90% cpu usage for the renderer to abt 30%

Dueris commented 1 year ago

i have now implemented the ActionOverTime power ticker code for intervaling, which should slow down the rate from 20 tps for that power to abt 2 tps per second for that power. that should greatly reduce cpu usage bc its not operating on the renderer until the 1/2 second has passed.

Dueris commented 1 year ago

now optimizing the chunk distance for it, it will run in a max of 7 chunks around the plyaer instead of the entire world. if theplayer render distance is smaller than 7 chunks it will run on that distacne

Dueris commented 1 year ago

alright i optimized it from using ~80-90% of the main thread to ~10-25%

Dueris commented 1 year ago

https://we.tl/t-d3XXkdpgWJ

A53o commented 1 year ago

Thx I will test this later today it's 8:40 am lol

A53o commented 1 year ago

its much better

A53o commented 1 year ago

but i still get this [23:48:42 WARN]: Can't keep up! Is the server overloaded? Running 5256ms or 105 ticks behind

Dueris commented 1 year ago

ye that will continue to happen from time to time due to how horribly unoptimized my code is lmao. which is why i have been working on optimizing it lol

A53o commented 1 year ago

ik your doing your best minecraft is just very unoptimized

Dueris commented 1 year ago

yeah. sad that folia isnt supported tho, genesis could benifete a lot form folia, but making folia 100% compatible would mean months of work. i tried doing it before and dropped the commit due to me changing so many things with everyhting still erroring bc genesis intertwines itself into all of the threads everywhere all at once, meaning every line would need to be run on a different thread. rly annoying lol

A53o commented 1 year ago

i might just have to wait for months as long as a have a plugin ill be happy it dose not matter how long i wait