Dueris / OriginsPaper

Custom Origins Plugin for PaperMC
https://modrinth.com/plugin/originspaper
Other
27 stars 4 forks source link

[BUG] - Cannot Select Origins in Top Section of UI #49

Closed shayd150 closed 9 months ago

shayd150 commented 9 months ago

Describe the bug The first section of the UI for the origins is broken and the origins in that section cannot be selected.

Plugin Version GenesisMC mc1.20-v0.2.3

Minecraft version 1.20.2

Server software Paper

Steps to reproduce When a player logs in and hasn't selected an origin, the origin selection on the first section is broken and origins cannot be selected.

What should happen? The first section of the origin UI should have worked and allowed for the selection of each origin in that section

What is happening instead? It shows the origin selection menu but the origins in the top section cannot be selected.

Stacktrace/Errors on Console [08:59:27 WARN]: [org.reflections.Reflections] could not get type for name org.mineskin.com.google.common.util.concurrent.internal.InternalFutureFailureAccess from any class loader org.reflections.ReflectionsException: could not get type for name org.mineskin.com.google.common.util.concurrent.internal.InternalFutureFailureAccess at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:312) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at org.reflections.Reflections.expandSuperTypes(Reflections.java:382) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at org.reflections.Reflections.(Reflections.java:140) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at me.dueris.genesismc.factory.powers.CraftPower.findCraftPowerClasses(CraftPower.java:23) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at me.dueris.genesismc.PlayerHandler.playerJoin(PlayerHandler.java:210) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor421.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:git-Paper-299] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.20.2.jar:git-Paper-299] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.20.2.jar:git-Paper-299] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at net.minecraft.server.players.PlayerList.placeNewPlayer(PlayerList.java:346) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.network.ServerConfigurationPacketListenerImpl.handleConfigurationFinished(ServerConfigurationPacketListenerImpl.java:130) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.handle(ServerboundFinishConfigurationPacket.java:18) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.network.protocol.configuration.ServerboundFinishConfigurationPacket.a(ServerboundFinishConfigurationPacket.java:9) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:53) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1324) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:193) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1301) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1294) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1272) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1160) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-299] at java.lang.Thread.run(Thread.java:1583) ~[?:?] Caused by: java.lang.ClassNotFoundException: org.mineskin.com.google.common.util.concurrent.internal.InternalFutureFailureAccess at java.net.URLClassLoader.findClass(URLClassLoader.java:445) ~[?:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:593) ~[?:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?] at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:310) ~[genesis-standalone-mc1.20-v0.2.3.jar:?]

Dueris commented 9 months ago

That error happens upon clicking the origins at the top of the menu?

Dueris commented 9 months ago

Bc that's a warning having to do with the skin programming, meaning it would be able to work past that due to it being a warning and not an error. Are there any other logs for when u press an origin at the top of the screen? Or when you hover over it does it say anything abt it being disabled?

shayd150 commented 9 months ago

Bc that's a warning having to do with the skin programming, meaning it would be able to work past that due to it being a warning and not an error. Are there any other logs for when u press an origin at the top of the screen? Or when you hover over it does it say anything abt it being disabled?

It does not disable the mod in the logs. I'm loading up to test a bit more and will provide any additional errors.

shayd150 commented 9 months ago

Bc that's a warning having to do with the skin programming, meaning it would be able to work past that due to it being a warning and not an error. Are there any other logs for when u press an origin at the top of the screen? Or when you hover over it does it say anything abt it being disabled?

It does not disable the mod in the logs. I'm loading up to test a bit more and will provide any additional errors.

This error I clicked on Enderian. I can click others and provide those as well if you like.

On an unrelated and more cosmetic note, the description text for Feline, Starborne, and Skulkling don't have text wrapping so their descriptions go off-screen. (I can submit a separate issue for this if you prefer. :) )

[10:05:32 ERROR]: Could not pass event InventoryClickEvent to GenesisMC vmc1.20-v0.2 java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Long (java.lang.String and java.lang.Long are in module java.base of loader 'bootstrap') at me.dueris.genesismc.utils.OriginContainer.getImpact(OriginContainer.java:138) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at me.dueris.genesismc.choosing.ChoosingCUSTOM.OriginChooseMenu(ChoosingCUSTOM.java:132) ~[genesis-standalone-mc1.20-v0.2.3.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor449.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:git-Paper-299] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.20.2.jar:git-Paper-299] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.20.2.jar:git-Paper-299] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.20.2-R0.1-SNAPSHOT.jar:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3108) ~[?:?] at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?] at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23) ~[?:?] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:53) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:193) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1301) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1294) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1324) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1272) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1160) ~[paper-1.20.2.jar:git-Paper-299] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-299] at java.lang.Thread.run(Thread.java:1583) ~[?:?]

Dueris commented 9 months ago

Why is it doing that lolll. I can fix this rq

shayd150 commented 9 months ago

Why is it doing that lolll. I can fix this rq

Sweet. Ty so much!

shayd150 commented 9 months ago

Adding that the affected origins you can't click are Avian, Arachnid, Elytrian, Shulk, Feline, Enderian, Merling.

In the process of using commands to set people to what they want, I discovered that hearts and armor are not reverted/changed after the origin is changed. I don't think items are taken back either. You may already be aware of this but I set a friend to arachnid two separate times and now they only have 1 heart. lol Seems like it's just subtracting 3 hearts each time instead of setting to 7 hearts and the other origins don't set to the default 10. If you'd like me to open another issue for this one please let me know

Hopefully that helps, and sorry I'm giving you all this stuff to do. XD

Dueris commented 9 months ago

Fixed