search

Duet3D / Duet3Expansion

GNU General Public License v3.0
22 stars 17 forks source link

Handler for CanMessageMovementLinearShaped uses fields from CanMessageMovementLinear #16

Closed dc42 closed 1 year ago

dc42 commented 1 year ago

From Andy: I've been running a lot of tests on beta 3 and toolboards and I noticed that I was getting a lot of "other" out of sequence movement messages reported. Digging into the code it looks like the handling of the new movementLinearShaped message in the expansion board CanInterface.cpp file was a copy/paste of the older movementLinear message. Unfortunately this has left code that references the msg.moveLinear part of the message union rather than the CanMessageMovementLinearShaped part. In general this seems not to cause problems (as the two structures match the first few fields), however it does impact the seq number member (which is a different size) which then causes the large number of errors I have been seeing reported. I'm not 100% sure that this is the only problem, but I think it is.

Anyway I thought I'd message you about it before I forget and in case anyone else reports the large numbers of errors: dup 0, oos 0/0/0/2760, bm 0, wbm 0, rxMotionDelay 768, adv 35269/107771

dc42 commented 1 year ago

Fixed in source code, in time for for 3.5.0-beta4.