search

Duet3D / DuetWebControl

A completely new web interface for the Duet electronics
GNU General Public License v3.0
408 stars 230 forks source link

Add two options - decimalPlaces and displayUnits #416

Closed MZachmann closed 2 years ago

MZachmann commented 2 years ago

decimalPlaces determines how many decimal places are shown in the dashboard coordinate display

displayUnits determines what unit of measure (inch/mm) is used for those coordinates as well as what units are used for the speeds (mm/s or ipm)

these only affect displayed values

chrishamm commented 2 years ago

It doesn't make sense to display more than three decimal places because reprapfirmware does not report a higher precision.

Mark Zachmann @.***> schrieb am Fr., 8. Apr. 2022, 18:30:

decimalPlaces determines how many decimal places are shown in the dashboard coordinate display

displayUnits determines what unit of measure (inch/mm) is used for those coordinates as well as what units are used for the speeds (mm/s or ipm)

these only affect displayed values

You can view, comment on, or merge this pull request online at:

https://github.com/Duet3D/DuetWebControl/pull/416 Commit Summary

File Changes

(7 files https://github.com/Duet3D/DuetWebControl/pull/416/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/Duet3D/DuetWebControl/pull/416, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNFFWNQJXRIPFZ7WECMYYLVEBNL5ANCNFSM5S5B2KQQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MZachmann commented 2 years ago

ok. is that also true in inches?

chrishamm commented 2 years ago

I am sure about mm because that's what is reported to and displayed on Dwc.

MZachmann commented 2 years ago

I'm trying to add both inch display support and selectable decimal places. Since the options are closely linked in the structure I just did a pull for both changes.

I started from needing 2 decimal places (for mm), then wanting it in inches, then needing 3 decimal places and thinking about 4 for rare tests. Having imperial is a huge convenience when working in the US and this code change is so benign.

chrishamm commented 2 years ago

Thanks, I'll have a look!

MZachmann commented 2 years ago

Thank you.