search

Duet3D / DuetWebControl

A completely new web interface for the Duet electronics
GNU General Public License v3.0
408 stars 230 forks source link

Improve UX for cancelling and resuming objects #433

Closed NicholasFeldman closed 1 year ago

NicholasFeldman commented 1 year ago

The current prompts for cancelling or resuming objects is a little ambiguous. When cancelling you get the options "Ok" and "Cancel", and both would logically mean "Yes, I want to cancel".

This PR changes them to "Yes", and "No", and adds an "Are you sure you want to cancel?" prompt.

Additionally, it changes the dialog to use i18n for the content.

Sindarius commented 1 year ago

I think changing the ok / cancel to yes / no is fine but I think adding an additional "are you sure?" confirmation is unnecessary. You're already going through 2 clicks to cancel an object. Selecting the object then the first dialog.

NicholasFeldman commented 1 year ago

To clarify, there isn't an additional click/step added, the prompt is added to the dialog card

Kriechi commented 1 year ago

I think changing the ok / cancel to yes / no is fine [...]

I don't think this is fine. OK/Yes/No buttons are unintuitive UX and can cause mistakes quickly and easily. The IMO better choice is to clearly label the buttons with what they will do: "Cancel object" / "Resume object" or "Dismiss" / "Do nothing" / "Close" to close the dialog without further action.

chrishamm commented 1 year ago

I'll leave it up to @Sindarius to decide. Closing for now.