Duet3D / DuetWebControl

A completely new web interface for the Duet electronics
GNU General Public License v3.0
408 stars 230 forks source link

[Bug]: Cannot print a file with a single quote in the name #435

Closed pfn closed 1 year ago

pfn commented 1 year ago

Duet Forum Discussion Thread

https://forum.duet3d.com/topic/30305/cannot-print-a-file-containing-single-quotes-from-dwc

Which Duet products are you using?

Firmware Version

3.4.0

Duet Web Control Version

3.4.0

Are you using a Single Board Computer (RaspberryPi) with your Duet?

Please upload the results of sending M122 in the gcode console.

No response

Please upload the content of your config.g file.

No response

Please upload the content of any other releveant macro files.

No response

Details specific to your printer.

No response

Links to additional info.

No response

What happened?

Expected result

Can print files containing single quotes from DWC

Observed result

RRF responds with a file not found error and the single-quote is stripped out, the subsequent letter is lowercased if it is upper-cased

Steps to reproduce

Try printing any file containing single quotes from DWC's jobs tab.

This is caused by https://docs.duet3d.com/en/User_manual/Reference/Gcodes#quoted-strings which removes single quotes. code reference https://github.com/Duet3D/RepRapFirmware/blob/3.4-dev/src/GCodes/GCodeBuffer/StringParser.cpp#L1384

x0rtrunks commented 1 year ago

Thanks for the report. This should be solved in 3.5.