Duet3D / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
945 stars 535 forks source link

[FeatureRequest] Add M303 cancelling to M108 #1010

Open droftarts opened 6 months ago

droftarts commented 6 months ago

Currently, nothing can cancel M303 heater tuning except emergency stop. Add cancelling M303 to M108. May be related to #765 (Allow aborting macros Including homing moves - "not quite an emergency, but STOP")

Forum discussions: https://forum.duet3d.com/topic/35735/m0-still-not-working-to-cancel-heater-pid-tuning https://forum.duet3d.com/topic/30848/unexpected-behaviour-3-5-0b1

Slack conversation: @dc42: If we are going to allow it to be cancelled, it would make more sense to use M108 for that purpose. Meanwhile, use estop. It's not really the same as that other issue (which itself covers a few different things) (#765).