Duet3D / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
939 stars 532 forks source link

Allow feed-rate override on G38 straight probes #1048

Closed benagricola closed 6 days ago

benagricola commented 1 week ago

I posted a forum thread a while ago about this (which may have been missed), but I noticed today on reprap.org that G38 commands already have the F parameter defined as a feed-rate override, but this is not currently supported by RRF.

This PR implements the F parameter on G38 straight probes, allowing the default probing speed to be overridden.

Ideally we could select to use the already-defined probe speeds directly, although with this PR that could be achieved in a roundabout way, without having to modify the probe speeds or machine limits temporarily:

G38.3 K{var.probeId) X140 F{sensors.probes[var.probeId].speeds[0]}
G38.3 K{var.probeId} X140 F{sensors.probes[var.probeId].speeds[1]}

etc.

Tested locally to confirm that this applies the speed override when specified and applies the default speed when not.