Duet3D / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
942 stars 534 forks source link

Thermostatic fan control not working for H101 #107

Closed notnyt closed 7 years ago

notnyt commented 7 years ago

M106 P2 T60 H101 logic seems to be broken and ends up running the fan continuously regardless of the temperature.

M106 P2 Fan2 frequency: 250Hz, speed: 100%, min: 10%, blip: 0.10, inverted: no, trigger: 60C, heaters: 101

I confirm the behavior works normal for this when using H1 and H100

RepRapFirmware for Duet WiFi version 1.19beta2 running on Duet WiFi 1.0

notnyt commented 7 years ago

Is the TMC2660 temperature only reporting as 0, 100, or 150?

https://github.com/dc42/RepRapFirmware/blob/6d41bf935c54051a97cff1c69d31ef8678292eea/src/Platform.cpp#L2104-L2106

notnyt commented 7 years ago

11.3 Overtemperature Detection The TMC2660 integrates a two-level temperature sensor (100°C warning and 150°C shutdown) for diagnostics and for protection of the power MOSFETs

dc42 commented 7 years ago

Yes.

dc42 commented 7 years ago

The operands of the >= operator at lines 2107 and 2119 of Platform.cpp should be reversed. Will fix in next beta.