Duet3D / RepRapFirmware

OO C++ RepRap Firmware
GNU General Public License v3.0
932 stars 533 forks source link

[Bug]: M954 by itself doesn't output the set CAN address #926

Closed jaysuk closed 3 months ago

jaysuk commented 9 months ago

Duet Forum Discussion Thread

N/A

Which Duet products are you using?

Firmware Version

3.4.6

Duet Web Control Version

3.4.6

Are you using a Single Board Computer (RaspberryPi) with your Duet?

Please upload the results of sending M122 in the gcode console.

N/A

Please upload the content of your config.g file.

N/A

Please upload the content of any other releveant macro files.

N/A

Details specific to your printer.

N/A

Links to additional info.

N/A

What happened?

It's expected that when a Gcode that doesn't have any arguements outputs it's assigned value M954 doesn't and it expects Ax to also be included

dc42 commented 6 months ago

What would be the purpose of this? The CAN address of the main board is always zero, and to use M954 on an expansion board you need to specify its CAN address using the B parameter. Either way, you already know the CAN address. The only situation in which I think it has a possible use is if you configure a main board as an expansion board, and then send commands directly to that board over USB or UART; but that's an odd use case.

T3P3 commented 3 months ago

not planned until we understand a usecase.