Dugy / Legend_of_the_Invincibles

An add-on campaign for the Battle for Wesnoth game
GNU General Public License v3.0
40 stars 22 forks source link

Shockwave in Gladiators may softlock the game #351

Closed Discontinuum closed 3 years ago

Discontinuum commented 3 years ago

A minor issue reported on the forums: if shockwave pushes an enemy out of the arena, the game is softlocked

Dugy commented 3 years ago

That might be because pushing a unit out of the map moves it to the recall list, so it becomes impossible to kill.

There are two easy solutions to this. Either to make the map larger on the bottom so that it would be extremely unlikely to happen or to consider only units on the map. I think the latter would be better, but before I do it, I'd like to give space for some objections, because my assumptions might be incorrect.

Discontinuum commented 3 years ago

Well, the case reported here https://forums.wesnoth.org/viewtopic.php?p=668185#p668185 is less sophisticated, not to that the recall list

image

Dugy commented 3 years ago

I thought you meant the MP scenario, not the chapter 8 scenario 9 that inspired it.

It looks like checking only units in the area not just units owned by the side should do the trick.

Discontinuum commented 2 years ago

The patch doesn't count villages and rubble, if the only enemy is on village or on rubble, the game declares this round to be won

Like this (Dracolich on the village) dfgg