Use bold colors - Githubissues

Duhemm / sbt-errors-summary

sbt plugin to show a summary of compilation messages.

MIT License

201 stars 11 forks source link

Use bold colors #8

Closed japgolly closed 7 years ago

japgolly commented 7 years ago

With the default colour schemes for xTerm, Linux console, Rxvt, the dark blue on black background is near unreadable. Bold blue would be much better. Red is similar but not as bad:

japgolly commented 7 years ago

I was thinking it might be an idea to make all the colours configurable but on the other hand, it's just as easy to fork and local publish for oneself. I made mine look like this:

Duhemm commented 7 years ago

Thanks for the report! I just tried your branch. The result of your whole set of changes look really good, and make everything even easier to read.

Would you mind opening a PR with your config?

japgolly commented 7 years ago

Yeah I was going to ask you about that. I made a bunch more changes, are you happy with all of them? I can create a PR with all the changes or just a subset that you're happy with.

To summarise my changes:

changed colours of filenames
made most colours bold so they are more readable on black backgrounds (at least in my envs)
in the by-filename report at the end
- sort by filename
- only print if more than one file
- print total error/warning count per file
- don't print line numbers
- consolidate problem ids where possible (eg. [1-4,9] instead of [1,2,3,4,9])
print total errors and warnings

Duhemm commented 7 years ago

All of them sound good to me! Looking forward to the PR!

japgolly commented 7 years ago

Great, I'll get a PR ready later this week!

Duhemm commented 7 years ago

Hey @japgolly, I've been looking in more details at your changes, and I had missed that you removed the line numbers from the summary. That's basically the reason why I created this reporter :( Can you think of a way of adapting your changes while keeping the line numbers from the summary? Maybe a flag that would let users switch between the 2 modes?

Duhemm commented 7 years ago

@japgolly Colors and such are now completely configurable. You can set, for instance:

reporterConfig := reporterConfig.value.withErrorIdColor(BLUE + BOLD)
                                      .withSourcePathColor(YELLOW + UNDERLINED)