Closed dleehr closed 6 years ago
I have not tested that the email templates use the transfer_id as expected - emailing was out of scope for this feature so I've been constructing the URLs manually
Summary of my testing on local dev environment:
s3 mb s3://d4s2-test-2018-04-25
s3 cp d4s2-test-2018-04-25/hello.txt s3://d4s2-test-2018-04-25
datadelivery deliver -b d4s2-test-2018-04-25 --email receiver-email@domain.com
transfer_id
from the S3 delivery:
python manage.py shell
>>> from d4s2_api.models import S3Delivery
>>> str(S3Delivery.objects.first().transfer_id)
'0c328d98-b40a-4e12-ba3b-64076db6b7f5'
delivery_type
and transfer_id
http://localhost:8000/ownership/?delivery_type=s3&transfer_id=0c328d98-b40a-4e12-ba3b-64076db6b7f5I'm still reviewing this, accidentally click the wrong option.
@johnbradley: 07875ccfb872f912e7e3f33072f2d79f57da8000 adds consistent checking for completed deliveries in the areas you caught.
DeliveryType
classtransfer_id
field to S3Delivery, as an auto-generated UUIDdecline_delivery
intoDeliveryUtil
delivery_type
field to HTML forms and query strings. Can be dds or s3. If missing, will default to ddsFixes #131