search

Duke-GCB / D4S2

Web service to facilitate notification and transfer of projects in DukeDS
MIT License
0 stars 0 forks source link

Updates email system to support S3 deliveries #145

Closed dleehr closed 6 years ago

dleehr commented 6 years ago

Adds a data migration to replace "Duke Data Service" in email templates with "{{ service_name }} Updates email context dictionaries to include service_name Adds a function to generate acceptance urls

Fixes #140

Tested in local development instance with the genomic-analysis email templates:

DDS steps:

  1. Loaded the data from current production server to my local django instance
  2. Set local passwords for django user accounts dcl9@duke.edu and jpb67@duke.edu
  3. Set email template set for dcl9 to be genomic-analysis
  4. Configured ddsclient to use the d4s2 server at http://localhost:8000
  5. Sent a delivery from dcl9 to jpb67.
  6. Verified the email printed to console appeared and provided clickable accept url with delivery_type=dds
  7. Logged into django instance as jpb67@duke.edu (with locally set password) and accepted the delivery
  8. Confirmed acceptance email displayed
  9. Repeated steps 5-8 with decline

Attempted to verify share emails working as expected, but encountered #144

S3 Steps:

Repeated testing from https://github.com/Duke-GCB/D4S2/pull/139#issuecomment-384396431. Confirmed accept and decline emails sent as expected