Update zipbuilder to handle leading-slash DukeDS remote paths

Duke-GCB / D4S2

Web service to facilitate notification and transfer of projects in DukeDS

MIT License

0 stars 0 forks source link

Update zipbuilder to handle leading-slash DukeDS remote paths #213

Closed johnbradley closed 5 years ago

johnbradley commented 5 years ago

The next version of DukeDSClient to be released adds a leading slash to remote paths: See PR https://github.com/Duke-GCB/DukeDSClient/pull/250. When D4S2 is upgraded to this version changes may be needed to where PathToFiles is used in zipbuilder: https://github.com/Duke-GCB/D4S2/blob/379399dc229fffbcc47b4866cb97213e08c83a1c/download_service/zipbuilder.py#L77-L79

johnbradley commented 5 years ago

I manually tested this and zipstream.ZipFile handles the leading slash without any modification necessary to D4S2. Closing since it will not break when we upgrade DukeDSClient.