search

Duke-GCB / DukeDSClient

Command line program to allow uploading, downloading, and managing projects in the duke-data-service.
MIT License
5 stars 6 forks source link

fix issue with logic to lookup delivery share users #233

Closed johnbradley closed 5 years ago

johnbradley commented 5 years ago

Method name change was missed in https://github.com/Duke-GCB/DukeDSClient/pull/210/files#diff-159eb799db1aac126081c2f824ebde1a

Fixes #232

johnbradley commented 5 years ago

The problem here was that the method name changed fetch_all_users to fetch_users. We had a test for this in the class that failed but the mocked class allowed the old name. Wondering if there is a way to have a mock check that the mocked methods actually exist in the real object.

johnbradley commented 5 years ago

I'm going to pull this back to to try this https://docs.python.org/3/library/unittest.mock.html#autospeccing