Duke-GCB / DukeDSClient

Command line program to allow uploading, downloading, and managing projects in the duke-data-service.
MIT License
5 stars 6 forks source link

Improve downloading checksum/communication #240

Closed johnbradley closed 5 years ago

johnbradley commented 5 years ago

When projects are uploaded by DukeDSClient an MD5 checksum is included and stored by DukeDS. This value is used when retrying a download. If the local file has the same MD5 checksum that file is not re-downloaded. I previously thought the MD5 checksum was validated for files that were downloaded, but this is not the case.

Change the download process to check the MD5 checksums for downloaded files. Also we should inform the users that the files have been downloaded and this check performed.