search

Duke-Jones / RegulatedNoise

32 stars 11 forks source link

fix invalid cast from EDCommoditiesExt to int #30

Closed WiredSharp closed 9 years ago

WiredSharp commented 9 years ago

replace the int cast by EDCommoditiesExt Id lookup. Add a CurrentCommodity property in order to retrieve the currently selected commodity.

Duke-Jones commented 9 years ago

hi. i will check this. thx for helping

Duke-Jones commented 9 years ago

I guess there something went wrong on your changes. A user in the german forum reported a crash in the 0.19 if he starts the view of the warnlevels. The v0.18 is running without problems - I can't reproduce the crash on my computer. Can you have a look on your changes, please ?

http://www.elitedangerous.de/forum/viewtopic.php?f=66&t=6404&start=100#p118647

WiredSharp commented 9 years ago

Hi, i Will check it quickly, i hope we will soon have unit tests for localisation issue as they may be hard to catch with regular validation

WiredSharp commented 9 years ago

Do You open any issue i should refer?