DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

Clean up job for inactive NetIDs #545

Open chrislorch opened 4 years ago

chrislorch commented 4 years ago

Describe the bug

A number of users are listed in Toolkits as "missing" since they're no longer at Duke. Loading these "phantom users" may cause problems for certain tools, particularly in older projects or larger courses.

Screenshots Toolkits_Missing

Additional context Sakai Lessons tool is having page load issues because of this problem. Longsight deployed a patch to help with performance issues on high enrollment sites.

(Discussed in MS Teams on 5/22)

swwalker commented 4 years ago

Originally noted in Sakai, same issue would apply to Toolkits and Kits.

How to distinguish active vs. hidden in the list? Currently, people who are no longer active at Duke and people who have opted to hide their information are displayed the same way. The application only knows that the entry can't be found in LDAP.

Need to determine what the long term solution is.

joliet commented 3 years ago

Liz has talked with IdM about cleaning up inactive NetIDs in Kits periodically. This does not solve the issue in Sakai though as those membership lists are maintained separately. We'll need to make sure that when a user clicks Add Participants that removed inactive users in the kit are also removed from Sakai.

ewendland23 commented 3 years ago

Kirk and I have a plan for removing Kits inactives. He mentioned that currently OneLink users never 'go inactive' but they are working on a process where they will be inactive if they don't log in for a year. Just putting this here as an FYI.

joliet commented 3 years ago

Same as this issue? https://github.com/DukeLearningInnovation/kits/issues/639

joliet commented 3 years ago

Another related issue - https://github.com/DukeLearningInnovation/kits/issues/557

joliet commented 2 years ago

Follow up with LS if Liz can't query to get eppn from 20-digit number. Check with LTS about removing these users.

Two policy groups - Kits Active, Kits Inactive. If not in either Liz will remove them. LS could maybe use these?

joliet commented 2 years ago

Need to figure out how to remove inactive users from Sakai.

joliet commented 2 years ago

Some details from the ticket with LS about how to proceed with consistently identifying inactive Duke users in Sakai sites.

From ticket between Jolie, Liz, and Sam at Longsight:

Example site on Sakai-test: https://sakai-test.duke.edu/portal/site/0116db09-df68-4e80-a768-1b66153bcb69/tool/fd6346c9-32d1-4bb5-a889-09d5a1249360?panel=Main

Sam made this change on Sakai-test: "You will now see "-" for first name and last name for users that can't be found in LDAP. This should put them at the top of the list in Site Info -> Manage Participants. The "unregistered" should no longer appear. I believe you should be able to remove the user from a site via webservices just fine, but if you have issues, please let me know."

https://support.longsight.com/hc/en-us/requests/72912

Confirm with LTS in DLI inactive users should be removed from course sites and follow up with Liz.

joliet commented 2 years ago

@ewendland23 Does the inactive users group Kirk created for you include inactive OneLink users? I assume yes but was asked by our team and wanted to check.

ewendland23 commented 2 years ago

Hi Jolie, I do not know. Kirk should be able to answer that though.

Thanks! LIZ

From: Jolie Tingen @.> Date: Friday, January 21, 2022 at 1:54 PM To: DukeLearningInnovation/kits @.> Cc: Liz Wendland @.>, Mention @.> Subject: Re: [DukeLearningInnovation/kits] Clean up job for inactive NetIDs (#545)

@ewendland23https://urldefense.com/v3/__https:/github.com/ewendland23__;!!OToaGQ!8KXtafhuEO2KIS1JzAX9jRDclYMJUKfjmMz_xHk_aKjKr4lV60FvKJNVFbL6$ Does the inactive users group Kirk created for you include inactive OneLink users? I assume yes but was asked by our team and wanted to check.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/DukeLearningInnovation/kits/issues/545*issuecomment-1018775011__;Iw!!OToaGQ!8KXtafhuEO2KIS1JzAX9jRDclYMJUKfjmMz_xHk_aKjKr4lV60FvKBGcNggD$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABCQCCCDFOJDPHG3V23UO2LUXGTWRANCNFSM4NMGWZCA__;!!OToaGQ!8KXtafhuEO2KIS1JzAX9jRDclYMJUKfjmMz_xHk_aKjKr4lV60FvKJnm4Mnf$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!OToaGQ!8KXtafhuEO2KIS1JzAX9jRDclYMJUKfjmMz_xHk_aKjKr4lV60FvKL7D3bNO$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!OToaGQ!8KXtafhuEO2KIS1JzAX9jRDclYMJUKfjmMz_xHk_aKjKr4lV60FvKIZhkRd8$. You are receiving this because you were mentioned.Message ID: @.***>

joliet commented 2 years ago

Follow up with Kirk/Longsight on why some users still have data in this site from F12. e.g. Why do some students have data (firstname, lastname) and not others.

ewendland23 commented 2 years ago

Hi Jolie,

I just checked in Grouper for the course STRATEGY.835.206.F12. I do not see anything nearly that old. The oldest offering of that course is from academic year 2015. Perhaps the Grouper rosters are removed if they are older than that? Another question to ask Kirk about?

joliet commented 2 years ago

@ewendland23 I confirmed with Marty and the rest of the LTS team that it is ok to move forward with the -,- modification for naming inactive users in Sakai sites. Marty prefers that we only remove inactive users from project sites in Sakai. We are not removing any inactive users from course sites at this time.

I followed up with Sam at Longsight confirming we can proceed with the -,- naming modification.

Jolie