DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

Collaboration kits should set up Sakai project sites instead of course sites #617

Open joliet opened 3 years ago

joliet commented 3 years ago

I am staff member trying to use Kits to set up a project site for my department but there is no option for project site during set up. I can only set up a course site. This makes me feel confused and frustrated.

How might we (the Kits project team) design user-created kits with the type Collaboration set up Sakai project sites instead of course sites?

Questions

Assumptions

Hypotheses Project sites do not use templates. That part of the set up page will have to be hidden or removed from project site set up. Site type in Sakai is a site property.

ewendland23 commented 2 years ago

@joliet - Can you be specific about what the settings are for a Sakai Project site? Or give an example site I should try to replicate? I am not sure what value to use for 'type' for example.

joliet commented 2 years ago

Hi @ewendland23 . The site type for a project site is different than a course site. Type is a Sakai site property and project sites have the type of 'project' for the 'type' property.

We may not have had this as an option before. There are no templates used for project sites, users are prompted to make selections when they set up the site. Here is what those should be:

type = project TOS= accept, primary use (other) - not sure if this is something you need to set in your code, but those are the options if yes title = 'kit display name' sitetools (or sitePages?)= default selected (accept defaults and continue) props: published=yes; visibility=yes; access=limit

I'm guessing on some of these based on what I'm seeing here - https://sakai.duke.edu/direct/site/describe

joliet commented 2 years ago

This looks good! Can we drop the kit id from the name when we set up the site? I can't remember if we had any issues with that. Let's discuss at the team meeting today @ewendland23 .

joliet commented 2 years ago

Hi Liz. I tested setting up a project site with an older collaboration kit. It worked as expected except for two things: the site type property was set to course instead of project, and the site somehow got the template property it's self which made it show up in our course template list (likely because it was set to type course). Here are the kit and Sakai site details:

On Kits/Sakai production kit title: PROJECT 2021-01: Test Project Kit kit id: 50545 Sakai site title: PROJECT 2021-01: Test Project Kit Sakai site id: project-2021-01-test-project-kit

I'm happy to test more if that's helpful. Just let me know.

ewendland23 commented 2 years ago

@joliet - Good job! I missed setting the Site Type for collab kits. And also forgot that Sakai is annoying and the template change needs to be reset a few times until it 'sticks'. I made this fix and have put this on Kits Test. Can you please retest on Test?

joliet commented 2 years ago

@ewendland23 Re-tested this with the following kit /site:

kit title: TEAM 2021-04: Test for GH 629 kit id: 2233 Sakai site title: TEAM 2021-04: Test for GH 629 Sakai site id: team-2021-04-test-for-gh-629

A project site was created, but kit members with the role Owner were assigned maintain role in the site instead of Owner and those with role of Editor in the kit were assigned the role of access in the Sakai site.

ewendland23 commented 2 years ago

@joliet - This is happening because I backed out the role changes until we have the new roles on production.

joliet commented 2 years ago

@ewendland23 To confirm, you backed out those changes from Kits-test?

ewendland23 commented 2 years ago

Yes, @joliet - So I don't accidentally move them into production again before we are ready.

joliet commented 2 years ago

@ewendland23 Not sure if you are still working on this one but I just re-tested and while the project site had the correct site type - project - I was not added to the site as an owner. Here are details:

Kit title: TEAM 2021-10-27: Project Site Test Again Kit id: 2630 Sakai project site title: TEAM 2021-10-27: Project Site Test Again Sakai project site id: team-2021-10-27-project-site-test-again

ewendland23 commented 2 years ago

Hey Jolie,

It looks like they have removed the older roles from Sakai Test. Kits is trying to add you with role ‘maintain’ and that is failing.

I think we should just move this into production. We are going to struggle testing the roles until Test and Production match again. But that should be soon? Do you have a date?

Thanks! Liz

From: Jolie Tingen @.> Date: Wednesday, October 27, 2021 at 11:08 AM To: DukeLearningInnovation/kits @.> Cc: Liz Wendland @.>, Mention @.> Subject: Re: [DukeLearningInnovation/kits] Collaboration kits should set up Sakai project sites instead of course sites (#617)

@ewendland23https://urldefense.com/v3/__https:/github.com/ewendland23__;!!OToaGQ!-_WnPZbRRcUV7IaUXgZrLFSy3ZzkwIogF647q7c1ZittMlzJYFhnQqh16xfn$ Not sure if you are still working on this one but I just re-tested and while the project site had the correct site type - project - I was not added to the site as an owner. Here are details:

Kit title: TEAM 2021-10-27: Project Site Test Again Kit id: 2630 Sakai project site title: TEAM 2021-10-27: Project Site Test Again Sakai project site id: team-2021-10-27-project-site-test-again

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/DukeLearningInnovation/kits/issues/617*issuecomment-953025118__;Iw!!OToaGQ!-_WnPZbRRcUV7IaUXgZrLFSy3ZzkwIogF647q7c1ZittMlzJYFhnQtgobhkH$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABCQCCDZFPCGXWM3VIWNVILUJAIYNANCNFSM4XRH4S3A__;!!OToaGQ!-_WnPZbRRcUV7IaUXgZrLFSy3ZzkwIogF647q7c1ZittMlzJYFhnQi0SSzxZ$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!OToaGQ!-_WnPZbRRcUV7IaUXgZrLFSy3ZzkwIogF647q7c1ZittMlzJYFhnQrJDgUi6$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!OToaGQ!-_WnPZbRRcUV7IaUXgZrLFSy3ZzkwIogF647q7c1ZittMlzJYFhnQn1s3v2c$.

joliet commented 2 years ago

Yeah, this is right @ewendland23 . There's really no point in me testing this until we can get the roles sorted out. Did you see my question via email about the Editor role in old kits?

ewendland23 commented 2 years ago

I moved this to production. It will work with the existing roles and will also work once we add the new roles to prodution.

joliet commented 2 years ago

Sounds good @ewendland23 . I will do some verification testing on prod.