search

DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

Duplicate roles displayed for official course kits #676

Closed joliet closed 2 years ago

joliet commented 2 years ago

Describe the bug Roles are being displayed twice in the drop-down list when adding a new member to a kit.

To Reproduce Steps to reproduce the behavior:

  1. Go to kits-test.duke.edu
  2. As an admin, search for the kit Physical Chemistry I Lab F21 (kit id 2628)
  3. View/Edit members for kit
  4. Click Edit Mode
  5. In the role drop-down for Add Member see duplicate Instructor and Student roles

Expected behavior Only one listing for all roles in the drop down.

Screenshots If applicable, add screenshots to help explain your problem.

Duke_Kits_Edit_Members_

Additional context Add any other context about the problem here.

ewendland23 commented 2 years ago

This is happening because of issue 673. Let me fix that one and see if this goes away.

joliet commented 2 years ago

Thanks, Liz. I've checked a dozen or so course sites on Sakai/Kits TEST and don't see any duplicate role listing in the drop-downs. This looks fixed to me.