DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

Winter Term missing from in Kits #708

Closed joliet closed 2 years ago

joliet commented 2 years ago

Describe the bug Winter Term 2022 (an previous Winter terms) is missing from the semester drop-down menu under My Kits and from the Batch Create Sakai Sites feature.

To Reproduce Steps to reproduce the behavior:

  1. Go to My Kits.
  2. Click on Impersonate a User selecting a Law faculty member.
  3. Notice no Winter terms under semester drop-down.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots Winter Term should be an option under the semester drop-down menu and in the term selection for Batch Create Sakai Sites.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

joliet commented 2 years ago

Manually added Winter term for 2022. Will look for Winter in description or short description in SIS data to add to term query.

joliet commented 2 years ago

Will likely use Law's start and end dates of when to show Winter Term in My Kits.

joliet commented 2 years ago

I think we decided it would be hard for me to test this. I was thinking about batch creating some Sakai sites for Winter Term 2022 so that I would be able to see those in kits-test, but I'm not seeing that term in the Batch Create Sakai Sites feature. @noahhh and/or @ewendland23 , can we get Winter to show there so I have some kits to test with? Thanks!

noahhh commented 2 years ago

Hi @joliet. We take the current term and the 5 closest upcoming terms and the current term, so winter doesn't show up in the dropdown list yet. Should we increase the number of terms we display? Winter would show up at that point.

joliet commented 2 years ago

Hey @noahhh . If we are taking the next 5 upcoming terms, wouldn't we get Winter 2023? The current term is Spring 2022 and the next 5 terms would be Summer 1 2022, Summer 2 2022, Fall 2022, Winter 2023, and Spring 2023.

Unfortunately, Winter Term 2023 won't have any classes yet so I wouldn't really be able to get some test data for that term, just confirm it is showing up. Would it be better just to push this to prod? I assume faculty with Winter 2022 courses would see kits in that term, correct?

noahhh commented 2 years ago

@joliet the batch create sakai page includes DKU terms as well

joliet commented 2 years ago

Ah, I wondered if you meant DKU Terms as well @noahhh . I'm not sure about adding more terms. There would never be any courses that far out. Thoughts on just moving this to prod?

noahhh commented 2 years ago

@joliet Sure, I can go ahead and move this to prod

noahhh commented 2 years ago

@joliet this has been moved to production, here are the winter terms that are in the DB

"2007 Winter Term (FUQUA)" "2014 Winter Term" "2015 Winter Term" "2016 Winter Term" "2017 Winter Term" "2018 Winter Term" "2019 Winter Term" "2020 Winter Term" "2021 Winter Term" "2022 Winter Term" "2023 Winter Term" "2024 Winter Term" "2025 Winter Term" "2026 Winter Term" "2027 Winter Term" "2028 Winter Term" "2029 Winter Term" "2030 Winter Term" "2031 Winter Term" "2032 Winter Term" "2033 Winter Term"