DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

No results in Search All Kits when pressing enter in search box #712

Closed joliet closed 2 years ago

joliet commented 2 years ago

Describe the bug The original design of this feature was that pressing enter with the search box select and no text in the field would generate a list of all kits in reverse chronological order, i.e. the most recently-created kits. This functionality is not working.

To Reproduce Steps to reproduce the behavior:

  1. Go to the Admin Console
  2. Click on Search All Kits
  3. Put cursor in the search box with no text and press enter
  4. No results are displayed

Expected behavior Expected to see a list of kits created in reverse chronological order (most recent first).

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

joliet commented 2 years ago

Returns limit of 500 to improve how quickly results are returned.

noahhh commented 2 years ago

@joliet not sure the best way to test this, since test only has ~1,000 courses so we can't tell if there is a speed increase in page loading. It does show 50 pages of results instead of 100 or whatever it was before, so we know we are at least getting the 500 we are aiming for.

joliet commented 2 years ago

LGTM @noahhh . Ready for prod.