DukeLearningInnovation / kits

https://dukelearninginnovation.github.io/kits
GNU General Public License v3.0
37 stars 5 forks source link

Broken image links on app details page in App Store #716

Closed joliet closed 2 years ago

joliet commented 2 years ago

Describe the bug Links to images in app detail pages are broken.

To Reproduce Steps to reproduce the behavior:

  1. Go to Kits
  2. Click on App Store
  3. Click on app details for any app
  4. See broken images

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Screen Shot 2022-02-22 at 10 00 56 AM

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

joliet commented 2 years ago

Created this ticket in ServiceNow - https://duke.service-now.com/nav_to.do?uri=incident.do?sys_id=e9cfdc561b75419028c90f66624bcb62%26sysparm_view=itil

noahhh commented 2 years ago

Hi @joliet . I spoke with Dave White about this issue. It was easier for me to work on it than help him get set up with Kits again, as it was a fix that could be done within the Kits app. Let me know if you have issues with it, Dave walked me through what was wrong/what we needed to do.

joliet commented 2 years ago

Thanks, @noahhh . I'm still seeing the broken images even with a refresh. Are you still working on this?

noahhh commented 2 years ago

Interesting, I do not see broken links. Which apps do you see them for? Can you try a different browser/clear cache?

joliet commented 2 years ago

Ok @noahhh, I cleared cache and tested in all of these browsers - Chrome, Firefox, and Safari. The images on the app detail pages for all the apps were not showed - they showed as broken links. Let me know if you'd like me to do more testing.

noahhh commented 2 years ago

@joliet Ha, this is interesting. Are you on a Duke VPN? I couldn't see them until I connected to a VPN (I was on it the day of for development). If you can see them once you VPN I will talk to Dave White about that.

joliet commented 2 years ago

That's it, @noahhh ! I connected via VPN and the images are there.

noahhh commented 2 years ago

@joliet I spoke with Dave and he removed the Duke network restriction. Are you able to see the images now? This was also blocking images on the 'About' page, which looks fixed now as well.

joliet commented 2 years ago

This looks fixed @noahhh . Thanks! Closing.