DukeLivingHistory / RLH-Site-Code

This is the code for the InSite system for publishing Interactive Transcripts. The system was developed at Duke University and Duke's Rutherfurd Living History site (http://livinghistory.sanford.duke.edu/) uses the system. For more details see http://livinghistory.sanford.duke.edu/our-research
MIT License
6 stars 2 forks source link

Indent in Table of Contents #167

Closed KimPatch closed 6 years ago

KimPatch commented 6 years ago

Current Behavior: Both types of chapter headings are indented the same way table of contents drop-down._

Desired Behavior: If the two types of chapter headings are both present NOTE chapter should indent in table of contents drop-down._

Other details: See Contents Test on the staging site for an example file with nested chapters. If I'm remembering correctly, when we first added NOTE chapter these did nest.

The table contents should also nest according to <h tag Here's another example: http://rlhdemo.sanford.duke.edu/interactives/insite-guide-recording-transcribing-publishing-interviews/

And the drop-down box should also expand if there's room on the screen rather than requiring more scrolling.

ethanbutler commented 6 years ago

@KimPatch – this was not previously-discussed functionality, so this is an enhancement, not a bug. I'll have time to implement this next month.

KimPatch commented 6 years ago

@ethanbutler – great, sounds good

ethanbutler commented 6 years ago

@KimPatch - I pushed a change so that headings indent.

Your last concern – about users needing to scroll – depends on the browser UI, so there's not really anything we can do there.

Also, I would really strongly advise against using heading markup within a transcript file. The site is already set to generate the proper HTML for transcript based on the heading options established, so there is absolutely no need to do this. Doing so will generate non-semantic HTML, which is bad for accessibility. We can discuss this on our call next week if need be.

KimPatch commented 6 years ago

@ethanbutler The headings still don't indent in the table of contents drop-down. I added two tests to the staging site:

This is a simple test using the two types of headings image

This is a report from the site image

I was expecting the table of content to indent with both of these but neither does.

Question for you: What type of control do you have over the size of the drop down box – is it possible to make it bigger? Is it inadvisable for some reason? It looks like the bottom item is the same on both Firefox and Chrome:

image

ethanbutler commented 6 years ago

@KimPatch – to answer your questions:

  1. Headings do not indent because the parser only recognizes plain text and is designed to parse WebVTT, not HTML. It is not an HTML parser. To the parser, text with HTML markup is identical to text without. I can walk through this when we talk with Katie next week.
  2. The size of the text box is OS and browser dependent. We don't have control over this.

I'm marking this issue as closed.

KimPatch commented 6 years ago

@ethanbutler

  1. Understood – Editing this answer. I'm looking at the simple test headings and they do indent – thanks. I adjusted the other test so it uses the WebVTT tiers and now it indents as well. So now it looks good – thanks.
  2. Understood