search

DukeLivingHistory / RLH-Site-Code

This is the code for the InSite system for publishing Interactive Transcripts. The system was developed at Duke University and Duke's Rutherfurd Living History site (http://livinghistory.sanford.duke.edu/) uses the system. For more details see http://livinghistory.sanford.duke.edu/our-research
MIT License
6 stars 2 forks source link

Add quotation marks around shared excerpt #180

Closed KimPatch closed 5 years ago

KimPatch commented 5 years ago

Current Behavior: When the user selects an excerpt and hits the Facebook, Twitter or Link button, the excerpt is copied to the clipboard along with a link to the beginning of the nearest segment.

Desired Behavior: The excerpt should be also surrounded by quotation marks

KimPatch commented 5 years ago

@ethanbutler Thanks. Reopening this. There's an extra space before the closing quote. But there's a bigger issue that became apparent once I saw this in action.

If you select an excerpt that includes quote marks or a person's name, you'll get something grammatically wrong. People may also want to indent quotes, and in that case wouldn't use quote marks. I don't think we can get around these issues and so therefore should just roll 180 back.

So I think we should just keep this a simple copy without adding quotes.

(Here are a couple of examples – the first one is a simple excerpt – the only issue is the extra space:

"It made reporting harder, and I think it also deterred some normal conversation and pushing on the part of the press for the first two years. " http://livinghistory.sanford.duke.edu/interviews/dana-priest/#2594

Here's an excerpt where quote marks turn out not to be appropriate either at the beginning or at the end: "DANA PRIEST Well, or they didn’t drop an anonymous or other kind of note that says, “Hey, psst, did you hear what’s going on at the Agency?” " http://livinghistory.sanford.duke.edu/interviews/dana-priest/#1608)

KimPatch commented 5 years ago

looks good – thanks