search

DukeLivingHistory / RLH-Site-Code

This is the code for the InSite system for publishing Interactive Transcripts. The system was developed at Duke University and Duke's Rutherfurd Living History site (http://livinghistory.sanford.duke.edu/) uses the system. For more details see http://livinghistory.sanford.duke.edu/our-research
MIT License
6 stars 2 forks source link

Selection with link doesn't properly copy #62

Closed KimPatch closed 6 years ago

KimPatch commented 6 years ago

Current Behavior: When you select transcript text and click on the copy link and the selected text includes a hyperlink, the copy link doesn’t have a sentence number.

Desired Behavior: The copy link should always have a number.

Other details: Test: http://rlhdemo.sanford.duke.edu/interviews/2018-01-08-pr-test/

Select this and press copy button, get green feedback saying copy JOHN BRENNAN, CIA DIRECTOR, 2013-17 Well, in the days before the elections, there was constant interaction between the experts at CIA, FBI and NSA. We were monitoring and using our collection capabilities to understand what the Russians might have up their sleeve at the 11th hour.

Paste returns: JOHN BRENNAN, CIA DIRECTOR, 2013-17 Well, in the days before the elections, there was constant interaction between the experts at CIA, FBI and NSA. We were monitoring and using our collection capabilities to understand what the Russians might have up their sleeve at the 11th hour. http://rlhdemo.sanford.duke.edu/interviews/2018-01-08-pr-test/

There should be a number at the end of the URL, there isn’t.

Select just the title: JOHN BRENNAN, CIA Director, 2013-17 http://rlhdemo.sanford.duke.edu/interviews/2018-01-08-pr-test/#78

The number correctly appears at the end.

ethanbutler commented 6 years ago

@KimPatch – can you email me the password to the staging site?

KimPatch commented 6 years ago

Will do – ah, the demo site

ethanbutler commented 6 years ago

@KimPatch – it looks like what's going on is that because there's an tag around the highlighted element, the code isn't accessing the timestamp because the timestamp is on the parent element of the highlighted element.

I have an idea for how to fix this, which I'll implement later this week. Thanks!

KimPatch commented 6 years ago

That fixed the links, but now the number is not copying if the excerpt includes a heading: I moved this sample interview with links to the staging site (without video) http://rlh.demo.sqnts.xyz/interviews/pr/

Test results:

Links: This was the most aggressive and most direct and most assertive campaign that the Russians ever mounted in the history of our elections. And what characterized this were the variety and intensity of the techniques that they employed. http://rlh.demo.sqnts.xyz/interviews/pr/#123

JAMES CLAPPER, Dir. of Natl. Intelligence, 2010-17 This was the most aggressive and most direct and most assertive campaign that the Russians ever mounted in the history of our elections. And what characterized this were the variety and intensity of the techniques that they employed. http://rlh.demo.sqnts.xyz/interviews/pr/

No links: Now they detected what they call OPE, operational preparation of the environment. http://rlh.demo.sqnts.xyz/interviews/pr/#141

NARRATOR Now they detected what they call OPE, operational preparation of the environment. http://rlh.demo.sqnts.xyz/interviews/pr/

ethanbutler commented 6 years ago

@KimPatch – I've made a tweak that should fix this.

KimPatch commented 6 years ago

Looks good!