search

DukeLupus / dlFilter

dlFilter is a text filtering script for mIRC. It is created with both chat and file sharing channels in mind. dlFilter removes ads, requests, annoying KeepTrack, mp3 play & away messages and much more. Also, dlFilter can send notices from fileservers to separate window and group @find results, allowing them to be easily viewed.
Mozilla Public License 2.0
34 stars 1 forks source link

v210 spams channels that do not support searchbot #82

Closed Robertk95 closed 5 years ago

Robertk95 commented 5 years ago

merging SbClient and DlFilter functions need separate channel authorizations.

the following is a chat with a channel op on a channel that decided to go another route instead of searchbot.

Session Start: Sat Jul 27 11:10:27 2019 Session Ident: Troop [11:10] You are flooding the channel with this [11:10] 15:36] @SearchBot-Trigger [11:10] [15:37] @SearchBot-Trigger [11:10] [15:38] @SearchBot-Trigger [11:10] [15:39] @SearchBot-Trigger [11:10] [15:40] @SearchBot-Trigger [11:10] [15:41] @SearchBot-Trigger [13:27] Sorry about the @SearchBot-Trigger flood.. that appears to be the default setting of the mIRC script DLFilter [14:02] [dlFilter] Starting version 2.10 by DukeLupus & Sophist. [14:02] [dlFilter] Please visit dlFilter homepage (https://github.com/DukeLupus/dlFilter) for help. [14:02] [dlFilter] Added 572 wildcard templates [14:05] ok changed default delay to 5 minutes (I hope). [14:07] Further reading of script comments appear to indicate maintainer is attempting to merge the two scripts.. and hasn't quite figured out what to do when no channel ops are running the SearchBot script for the channel. [14:17] Is there no option to disable it completely, as it performs no useful function anyway [14:23] I will revert back to previous version dlFilter.. and send a cleaned copy of this conversation to the maintainer github page. [14:24] the updated DlFilter is overwriting (or ignoring) the channel options previously set in SbClient (both from the same coder.) on Close: Sat Jul 27 14:48:40 2019

Sophist-UK commented 5 years ago

@Robertk95

Thank you for reporting this. I am not sure what setting you were changing because this doesn't have a setting.

Can you please advise what requests you were making at the time (first token only needed - do not need full details of what you were requesting)? If possible, please provide a full log of all requests that were being made by you.

Sophist-UK commented 5 years ago

@Robertk95

P.S. Working on a fix right now and will let you know once it has been published. If you could then test it for me I would be grateful.

Robertk95 commented 5 years ago

Correct there is no setting. I was running current beta DlFilter (as of early last week) and SbClient v2.23.15 I am typically connected with either or both Undernet and IRCHighway (I hop by and sometimes leach on one channel on each network). Sadly a number of the people who served on the IRCHighway channel have passed on (I do miss our conversations.. sigh)

In the past servers who are normally in IRCHighway also started serving on our common Undernet channel. so I added that channel to the SbClient searchbot list.

I haven't seen the IRCHighway servers on Undernet lately but I did not change any settings. Then I installed V210 and a few days later a channel op contacted me with his notice of my spamming to the channel servers.. which you saw a stripped down sanitized selection.

What I did first was remove Undernet from the SbClient settings.. that did not stop the once a minute query.

Then after going through the DlFilter user settings very closely and finding nothing that seemed to have any effect on the query, I opened up DlFilter.mrc in an editor and started reading through the comments and code,

I had hope to eliminate the query for that channel only... not possible with out coding changes (as far as a quick check of the code seems to show.) Next I tried to placate the channel op by cutting back the query frequency without seriously impacting the section of the code on IRCHighway.

what I did was edit line 2448 as follows

; hack var %timeout 60 + %delay var %timeout 300 + %delay . The channel op was being nice about the whole thing, where he could have just banned me. So I returned the favor by reverting back to DlFilter 2.09

On Sun, Jul 28, 2019 at 8:12 AM Sophist notifications@github.com wrote:

@Robertk95 https://github.com/Robertk95

Thank you for reporting this. I am not sure what setting you were changing because this doesn't have a setting.

Can you please advise what requests you were making at the time (first token only needed - do not need full details of what you were requesting)? If possible, please provide a full log of all requests that were being made by you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DukeLupus/dlFilter/issues/82?email_source=notifications&email_token=AC2UVTXJC4COVXJJ7SONBFLQBWLKTA5CNFSM4IHKSNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD266MWQ#issuecomment-515761754, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2UVTTZCLCU47RGCPW4WNDQBWLKTANCNFSM4IHKSNRQ .

Sophist-UK commented 5 years ago

@Robertk95 - Thanks for the extra info. The quick fix you made is ok as a temporary one - but I am working on a much better one.

Can you please advise which network and channel you had the problem on?

Sophist-UK commented 5 years ago

Oh - and if you are willing to give the ops nick I can let him know about the fix.

Robertk95 commented 5 years ago

Privately yes.. publicly .. I Don't think that would make channel users happy.

On Sun, Jul 28, 2019 at 9:10 AM Sophist notifications@github.com wrote:

@Robertk95 https://github.com/Robertk95 - Thanks for the extra info. The quick fix you made is ok as a temporary one - but I am working on a much better one.

Can you please advise which network and channel you had the problem on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DukeLupus/dlFilter/issues/82?email_source=notifications&email_token=AC2UVTSWTCO33GMZU3ROMJDQBWSGTA5CNFSM4IHKSNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD267ODY#issuecomment-515766031, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2UVTUR7RVHKCK3JAGLBATQBWSGTANCNFSM4IHKSNRQ .

Robertk95 commented 5 years ago

sent an IRC chat.. in a common channel we are currently on.

On Sun, Jul 28, 2019 at 9:11 AM Robert Kohler robert6.kohler@gmail.com wrote:

Privately yes.. publicly .. I Don't think that would make channel users happy.

On Sun, Jul 28, 2019 at 9:10 AM Sophist notifications@github.com wrote:

@Robertk95 https://github.com/Robertk95 - Thanks for the extra info. The quick fix you made is ok as a temporary one - but I am working on a much better one.

Can you please advise which network and channel you had the problem on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DukeLupus/dlFilter/issues/82?email_source=notifications&email_token=AC2UVTSWTCO33GMZU3ROMJDQBWSGTA5CNFSM4IHKSNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD267ODY#issuecomment-515766031, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2UVTUR7RVHKCK3JAGLBATQBWSGTANCNFSM4IHKSNRQ .

Sophist-UK commented 5 years ago

Sorry - seemed it got filtered. Please ask in channel for me to open a query window.

Robertk95 commented 5 years ago

ok going back up on IRC

On Sun, Jul 28, 2019 at 9:50 AM Sophist notifications@github.com wrote:

Sorry - seemed it got filtered. Please ask in channel for me to open a query window.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DukeLupus/dlFilter/issues/82?email_source=notifications&email_token=AC2UVTWCRQKRTKPIF2DUDJDQBWW4BA5CNFSM4IHKSNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27AF7Q#issuecomment-515769086, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2UVTQYG46JRAPPZ7HVXQDQBWW4BANCNFSM4IHKSNRQ .

Sophist-UK commented 5 years ago

Fixed with 5121f314ecdfe0f8b4b97ab544ca5fcc3d2efd79 and version bumped.