Open agrahari-himanshu opened 1 year ago
The TokenTypes object with constant values lacks consistency
File path: packages/parser/src/constants/bhaiLangSpec.ts
Issue: Exported object name says TokenTypes, but all the keys in the object doesn't follow same pattern Ex:
Few that follows suffix as TYPE
Few that doesn't follow suffix as TYPE
Impact of inconsistency: Misleading keys of exported object.
Suggesation: We can have consistent keys, all of them having the suffix as TYPE
Bhai Lang
Refactoring
Description
The TokenTypes object with constant values lacks consistency
File path: packages/parser/src/constants/bhaiLangSpec.ts
Issue: Exported object name says TokenTypes, but all the keys in the object doesn't follow same pattern Ex:
Few that follows suffix as TYPE
Few that doesn't follow suffix as TYPE
Impact of inconsistency: Misleading keys of exported object.
Suggesation: We can have consistent keys, all of them having the suffix as TYPE
Domain
Bhai Lang
Type of Contribution
Refactoring
Code of Conduct