DummyClassOrg / main

dummy for issue
0 stars 2 forks source link

[400]Students with exact same name can be added. #1615

Open nus-pe-script opened 5 years ago

nus-pe-script commented 5 years ago

Describe the bug Students with exact same names can be added.

To Reproduce Steps to reproduce the behavior:

  1. a n/BtsyCrowe g/female nat/MY t/friend e/betsycrowe@examplecom a/Newgate Prison p/1234000000007 t/asdaskjkasdbfalsdfnlaskdnf
  2. a n/BtsyCrowe g/female nat/MY t/friend e/betsycroweexam@plecom a/Newgate Prison p/12340000007 t/asdaskjkasdbfalsdfnlaskdnf
  3. a n/BetsyCrowe g/female nat/MY t/friend e/betsycrowe@examplecom a/Newgate Prison p/1234567 t/asdaskjkasdbfafnlaskdnf

Expected behavior A warning should be shown

Screenshots image

Additional context Add any other context about the problem here.

OS and Java Version


[original: nusCS2113-AY1819S1/pe-2#408]


Comment by Tsuweiquan

Explanation: Students with the exact name can be added if they both have different email address's and different phone numbers.

a n/BtsyCrowe g/female nat/MY t/friend e/**betsycrowe@examplecom** a/Newgate Prison p/**1234000000007** t/asdaskjkasdbfalsdfnlaskdnf

a n/BtsyCrowe g/female nat/MY t/friend e/**betsycroweexam@plecom** a/Newgate Prison p/**12340000007** t/asdaskjkasdbfalsdfnlaskdnf

The 2 examples given by the user (as shown above) shows that the criteria has been met where both students with the same name has different email address's and different phone numbers.

a n/BetsyCrowe g/female nat/MY t/friend e/betsycrowe@examplecom a/Newgate Prison p/1234567 t/asdaskjkasdbfafnlaskdnf was allowed because the student's name is different.

This is intended as having the same name among students are not uncommon, hence multiple students with the same name can be added into SMS, they are however still unique.


[original: DummyTA1/main#400]

proposed-assignees: novin997, rajdeepsh, e0176882, tsuweiquan, clara1234566,

Tutor to check: