Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

[BUG] adding new color field not working properly #422

Closed Dun-sin closed 1 year ago

Dun-sin commented 1 year ago

Description

In any generator that uses the color feature, there's an option to add extra colors, but when the button is clicked, it adds to fields instead of one per click.

Screenshots

https://github.com/Dun-sin/Code-Magic/assets/78784850/89078e84-815d-44dd-ba86-69daa9777f01

Additional information

No response

πŸ₯¦ Browser

Mozilla Firefox

πŸ‘€ Have you checked if this issue has been raised before?

🏒 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

github-actions[bot] commented 1 year ago

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

JohnChizzy commented 1 year ago

Hello, I will like to work on this issue

Dun-sin commented 1 year ago

Hello, I will like to work on this issue

Definitely, thanks for wanting to contribute, Make sure you follow the rules πŸ‘‰πŸ½hereπŸ‘ˆπŸ½, else your PR will not be accepted and will be closed. Good Luck.

JohnChizzy commented 1 year ago

sorry, let me have a solid grasp of the issue pls. like you want the add button to add just one colour field per click, right? pls, I need clarification on the issue

https://github.com/Dun-sin/Code-Magic/assets/68906510/9aa3eee0-3c3f-403a-9bbe-2ab038d3205d

Dun-sin commented 1 year ago

sorry, let me have a solid grasp of the issue pls. like you want the add button to add just one colour field per click, right? pls, I need clarification on the issue

https://github.com/Dun-sin/Code-Magic/assets/68906510/9aa3eee0-3c3f-403a-9bbe-2ab038d3205d

Yes, you got it right

JohnChizzy commented 1 year ago

I have inspected the addNewColorPicker function. From what I have observed, It seems to work as expected. I haven't even done anything on it yet. The add button is already adding one field per click, right?
code magic addbutton

https://github.com/Dun-sin/Code-Magic/assets/68906510/a93d810f-e93f-4590-a251-1d4bea16687b

That is the function and video of it working as expected.

Dun-sin commented 1 year ago

I have inspected the addNewColorPicker function. From what I have observed, It seems to work as expected. I haven't even done anything on it yet. The add button is already adding one field per click, right?
code magic addbutton

https://github.com/Dun-sin/Code-Magic/assets/68906510/a93d810f-e93f-4590-a251-1d4bea16687b

That is the function and video of it working as expected.

Hmmmm, what browser are you using?

JohnChizzy commented 1 year ago

Chrome. I just checked Firefox and edge. It works fine on Firefox too. It seems to be an Edge browser issue. Check it out and see

Dun-sin commented 1 year ago

Chrome. I just checked Firefox and edge. It works fine on Firefox too. It seems to be an Edge browser issue. Check it out and see

I'm using Firefox so I don't think it's just an edge issue

JohnChizzy commented 1 year ago

OK. I will inspect it properly and find the cause of this behaviour discrepancy. And see how to make it work consistently across different browsers.