Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

fix: Multiple fields by add button #428

Closed JohnChizzy closed 1 year ago

JohnChizzy commented 1 year ago

Fixes Issue

My PR closes #422

👨‍💻 Changes proposed(What did you do ?)

Changed the parent container of the fields from a flexbox to a gridbox. As gridbox is more structured for multiple items.

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

containergrid

https://github.com/Dun-sin/Code-Magic/assets/68906510/f42f4106-ecae-42bc-90b8-7c7d926b02d2

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-magic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 2:25pm
Dun-sin commented 1 year ago

this doesn't fix the issue for me, did you test this only on your chrome?

JohnChizzy commented 1 year ago

this doesn't fix the issue for me, did you test this only on your chrome?

No, I tested it across different browsers, chrome, Firefox, and edge. It works fine on all.

Dun-sin commented 1 year ago

this doesn't fix the issue for me, did you test this only on your chrome?

No, I tested it across different browsers, chrome, Firefox, and edge. It works fine on all.

Very weird that just using a grid fixes this issue, but then again it doesn't for me so this isn't a fix, i will just close this because there's no way grid does that. Thanks for tryig tho

JohnChizzy commented 1 year ago

this doesn't fix the issue for me, did you test this only on your chrome?

No, I tested it across different browsers, chrome, Firefox, and edge. It works fine on all.

Very weird that just using a grid fixes this issue, but then again it doesn't for me so this isn't a fix, i will just close this because there's no way grid does that. Thanks for tryig tho

Alright. You are welcome. I look forward to contributing more

Dun-sin commented 1 year ago

hi @JohnChizzy, you can check this Issue instead: https://github.com/Dun-sin/Code-Magic/issues/429