Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

Fix bug] open results button showing wrongly #441 #444

Closed franxxu closed 1 year ago

franxxu commented 1 year ago

Fixes Issue

My PR closes #issue_number_here

👨‍💻 Changes proposed(What did you do ?)

fixed the bug

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-magic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2023 0:28am
Dun-sin commented 1 year ago

@franxxu this won't be merged until the compliance bot stops complaining

franxxu commented 1 year ago

I saw the complaint, which had nothing to do with my changes.  What should be done? On Sunday, August 27, 2023 at 08:32:04 AM EDT, Dunsin @.***> wrote:

@franxxu this won't be merged until the compliance bot stops complaining

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Dun-sin commented 1 year ago

I saw the complaint, which had nothing to do with my changes.  What should be done? On Sunday, August 27, 2023 at 08:32:04 AM EDT, Dunsin @.> wrote: @franxxu this won't be merged until the compliance bot stops complaining — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

it has everything to do with your changes, please look at rules of this project. Also your PR fixes the problem and creates a new one, the button doesn't show anymore unless the user uses the gradient text tool, and this wasn't meant to just fix the issue for gradient text but all generators

the rules can be found in the contributing.md file

franxxu commented 1 year ago

i see, will dig into it.!

Sent from Yahoo Mail for iPhone

On Sunday, August 27, 2023, 08:37, Dunsin @.***> wrote:

I saw the complaint, which had nothing to do with my changes.  What should be done? On Sunday, August 27, 2023 at 08:32:04 AM EDT, Dunsin @.> wrote: @franxxu this won't be merged until the compliance bot stops complaining — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

it has everything to do with your changes, please look at rules of this project. Also your PR fixes the problem and creates a new one, the button doesn't show anymore unless the user uses the gradient text button, and this wasn't meant to just fix the issue for gradient text but all generators

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

franxxu commented 1 year ago

Ok, this time i think it should be fixed.  What should i do now?   On Sunday, August 27, 2023 at 08:37:29 AM EDT, Dunsin @.***> wrote:

I saw the complaint, which had nothing to do with my changes.  What should be done? On Sunday, August 27, 2023 at 08:32:04 AM EDT, Dunsin @.> wrote: @franxxu this won't be merged until the compliance bot stops complaining — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

it has everything to do with your changes, please look at rules of this project. Also your PR fixes the problem and creates a new one, the button doesn't show anymore unless the user uses the gradient text button, and this wasn't meant to just fix the issue for gradient text but all generators

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>