Closed Taherpatrawala closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
code-magic | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Sep 24, 2023 5:01am |
@Taherpatrawala this doesn't work
@Dun-sin The pages/text-shadow.ts file is not passing outputElement, hence why text-shadow may not work, I didn't add that code as it was not asked in the issue, Can you please confirm what problem are you facing, is it particularly with the class I added? I just checked the tailwind class again and ran the output code in a different project and it works as expected.
@Dun-sin The pages/text-shadow.ts file is not passing outputElement, hence why text-shadow may not work, I didn't add that code as it was not asked in the issue, Can you please confirm what problem are you facing, is it particularly with the class I added? I just checked the tailwind class again and ran the output code in a different project and it works as expected.
Oh that's a mistake on my end, it's meant to be functional, someone brought this up and I forgot to fix the issue description, thought I did. It's super easy to do, just a line of code
Check this PR for reference -> #433
Heyy @Dun-sin just updated the file, check it out and let me know if this is alright...
Heyy @Dun-sin just updated the file, check it out and let me know if this is alright...
It's not, doesn't work, the issue says to test that it works with Tailwind. Please do that and fix the code accordingly.
Use the Tailwind playground -> https://play.tailwindcss.com/
@Dun-sin I ran the Tailwind code on the said website and it seems to be working fine, can you pls elaborate on what problem are you facing?
@Dun-sin I ran the Tailwind code on the said website and it seems to be working fine, can you pls elaborate on what problem are you facing?
Oh I guess it's from my end, my apologies, you did good.
Your PR is accepted thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star and joining the community discord server for more resources and opportunities to connect with others. ππ½hereππ½
:tada: This PR is included in version 2.66.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
This was my first actual Open Source contribution, thanks for allowing me to contribute :)
This was my first actual Open Source contribution, thanks for allowing me to contribute :)
no problem
feat #454
Fixes Issue #454 Added tailwind class for CSS text-shadow
My PR closes #454
π¨βπ» Changes proposed(What did you do ?)
Added the correct and tested TailwindCSS code for text-shadow property The code has been tested locally.
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots