Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

fix(pages): fix tailwind css code for input range #466

Closed beyzanur-seyhan closed 1 year ago

beyzanur-seyhan commented 1 year ago

Fixes Issue

**My PR closes #464

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

There was no tailwind css generator in the input range. I added.

βœ”οΈ Check List (Check all the applicable boxes)

Note to reviewers

πŸ“· Screenshots

image image

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2023 7:52pm
Dun-sin commented 1 year ago

this doesn't work image

beyzanur-seyhan commented 1 year ago

this doesn't work image

Okay. I tested it from Opera GX browser right now. It works. I think there is a problem with the browser. As a result of my research for the code, a class can be assigned to the input range in this way - https://github.com/tailwindlabs/tailwindcss/discussions/8748

Which browser are you using?

Dun-sin commented 1 year ago

this doesn't work image

Okay. I tested it from Opera GX browser right now. It works. I think there is a problem with the browser. As a result of my research for the code, a class can be assigned to the input range in this way - tailwindlabs/tailwindcss#8748

Which browser are you using?

i'm using Firefox

beyzanur-seyhan commented 1 year ago

this doesn't work image

Okay. I tested it from Opera GX browser right now. It works. I think there is a problem with the browser. As a result of my research for the code, a class can be assigned to the input range in this way - tailwindlabs/tailwindcss#8748 Which browser are you using?

i'm using Firefox

I can fix. Can you try again?

Dun-sin commented 1 year ago

this doesn't work image

Okay. I tested it from Opera GX browser right now. It works. I think there is a problem with the browser. As a result of my research for the code, a class can be assigned to the input range in this way - tailwindlabs/tailwindcss#8748 Which browser are you using?

i'm using Firefox

I can fix. Can you try again?

it works now, I'm guessing because of MOZ which is the specific styling for firefox

beyzanur-seyhan commented 1 year ago

this doesn't work image

Okay. I tested it from Opera GX browser right now. It works. I think there is a problem with the browser. As a result of my research for the code, a class can be assigned to the input range in this way - tailwindlabs/tailwindcss#8748 Which browser are you using?

i'm using Firefox

I can fix. Can you try again?

it works now, I'm guessing because of MOZ which is the specific styling for firefox

I think. I used this for the solution: https://css-tricks.com/sliding-nightmare-understanding-range-input/

beyzanur-seyhan commented 1 year ago

Your PR is accepted thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

do you want me to merge this on october for hacktober?

Yes, I want. Thank you :)

Dun-sin commented 1 year ago

:tada: This PR is included in version 2.66.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: