Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

[FEATURE] better styling for thumb/track radius #467

Closed Dun-sin closed 1 year ago

Dun-sin commented 1 year ago

Description

the styling is pretty basic for the checkbox and number input, you can do better for sure.

Drop a screenshot or image of what you want to change it to and let's discuss before i assign it to you.

Screenshots

image

Additional information

No response

👀 Have you checked if this issue has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

github-actions[bot] commented 1 year ago

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

dhananjay-Byte commented 1 year ago

i would like to work on this.

kantakshay commented 1 year ago

@Dun-sin What do think about these style checkboxes and input boxes?

If it is good to go then please assign it to me.

Screenshot (168) Screenshot (169)

Dun-sin commented 1 year ago

@Dun-sin What do think about these style checkboxes and input boxes?

If it is good to go then please assign it to me.

Screenshot (168) Screenshot (169)

How would you combine them together?

kantakshay commented 1 year ago

@Dun-sin I am new to typescript can you help me, how can I add styling, I am not able to find any class or id in input-range.ts or give me some time to figure it out

Dun-sin commented 1 year ago

@Dun-sin I am new to typescript can you help me, how can I add styling, I am not able to find any class or id in input-range.ts or give me some time to figure it out

why would you want to take an issue you don't know how to do? this issue also has nothing to do with typescript, just plain HTML and CSS because it's all about styling

kantakshay commented 1 year ago

@Dun-sin I am new to typescript can you help me, how can I add styling, I am not able to find any class or id in input-range.ts or give me some time to figure it out

why would you want to take an issue you don't know how to do? this issue also has nothing to do with typescript, just plain HTML and CSS because it's all about styling

sorry !

I got it now it took me a while to understand the files, these elements are present in the index.html page I will style them triggering their class or id name

is it okay?

Dun-sin commented 1 year ago

@Dun-sin I am new to typescript can you help me, how can I add styling, I am not able to find any class or id in input-range.ts or give me some time to figure it out

why would you want to take an issue you don't know how to do? this issue also has nothing to do with typescript, just plain HTML and CSS because it's all about styling

sorry !

I got it now it took me a while to understand the files, these elements are present in the index.html page I will style them triggering their class or id name

is it okay?

first check if they already have an existing style then you can just edit them, plus you didn't answer my question of how it will look when combined, i need to see that before you are assigned

kantakshay commented 1 year ago

@Dun-sin I am new to typescript can you help me, how can I add styling, I am not able to find any class or id in input-range.ts or give me some time to figure it out

why would you want to take an issue you don't know how to do? this issue also has nothing to do with typescript, just plain HTML and CSS because it's all about styling

sorry ! I got it now it took me a while to understand the files, these elements are present in the index.html page I will style them triggering their class or id name is it okay?

first check if they already have an existing style then you can just edit them, plus you didn't answer my question of how it will look when combined, i need to see that before you are assigned

There is no style assigned yet, and I will show you the look in a bit.

Taherpatrawala commented 1 year ago

Hey @Dun-sin can I be assigned to this issue? I am planning on making something like this image If a user clicks on the checkbox the input range element pops up with a transition

kantakshay commented 1 year ago

@Dun-sin This is how it will look check box (1)

Dun-sin commented 1 year ago

@Dun-sin This is how it will look check box (1)

Perfect

Bismay5467 commented 1 year ago

Hey @Dun-sin, @kantakshay! Is there any progress being made with this issue? If not, I'd like to work on it.

kantakshay commented 1 year ago

Hey @Dun-sin, @kantakshay! Is there any progress being made with this issue? If not, I'd like to work on it.

oh yess Screenshot (175)

Dun-sin commented 1 year ago

@Dun-sin why does this preview shrink all the time? just curious! preview

because it's the default width when you start to change it

Dun-sin commented 1 year ago

@kantakshay this has been open for too long, will unassign you if there's no pull request in 3 days

Dun-sin commented 1 year ago

:tada: This issue has been resolved in version 2.71.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: