Closed SaketKaswa20 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
code-magic | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 1, 2023 11:40am |
@SaketKaswa20 you got some errors to fix for typescript to let you go
@SaketKaswa20 can't merge your PR because if I do, it removes a future we previously have which is keeping a dropdown open, unless you want to fix it for the feature to still work and the fix the issue too.
Else i will close the PR
I will try to fix this.
Currently, on the deployed one, only one drop-down is open at a time. If we open another, the previous one closes.
Currently, on the deployed one, only one drop-down is open at a time. If we open another, the previous one closes.
yes that's correct
So, should I make it that it should allow to open multiple drop down at the same time?
So, should I make it that it should allow to open multiple drop down at the same time?
open the preview for this pr
and open the deployed, use both and you will see what i mean
Oh okay, got it! Will fix it.
Fixed it! Should I start a new PR for this?
Fixed it! Should I start a new PR for this?
You can push to an existing PR as long as you still have the branch
Made another branch and made those changes, and then bought those changes in this branch. Tested it locally and everything was running good. Hopefully I have done everything correct, was a bit confused. Please let me know if this is correct, else allow me to make a new PR.
Thank you so much for helping and guiding me.
Looks like it's not fixed, next option is to create a new PR
Sure, just give me 5 minutes!
Fixes Issue
My PR closes #468
👨💻 Changes proposed(What did you do ?)
Did the necessary changes in main.ts and after testing it locally it's working good.
✔️ Check List (Check all the applicable boxes)
Note to reviewers
📷 Screenshots
https://github.com/Dun-sin/Code-Magic/assets/105808363/53fabb23-b1b0-485d-ab69-e685f0eb09dd