Dun-sin / Code-Magic

All in one styling tool for developers
https://code-magic.vercel.app
MIT License
382 stars 204 forks source link

fix: Null properties removed from generated css code #497

Closed Bismay5467 closed 1 year ago

Bismay5467 commented 1 year ago

Fixes #486

✔️ Check List (Check all the applicable boxes)

📷 Screenshots

image

@Dun-sin I am still working on this issue, but I would like to have a initial review from your side. Any feedback or suggestion would be highly appreciated!

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-magic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:41am
Bismay5467 commented 1 year ago

@Dun-sin I have reverted back the changes you had asked for. I have resolved the review conversation as scrolling through so many reviews was causing a lot of confusion. Can you check once and let me know if any other part of the code need to be reverted back?

I will commit new changes related to this issue once all the reviews are resolved to avoid confusion.

Dun-sin commented 1 year ago

@Bismay5467 You missed a few things, doesn't work for tailwind code that still copies

Bismay5467 commented 1 year ago

You missed a few things, doesn't work for tailwind code that still copies

Yeah, I know. I am trying to fix it for css first. Once this works while generating css code, doing the same for generating tailwind css would be a cakewalk.

Bismay5467 commented 1 year ago

your Pr should only contain generators that don't have the get results button

@Dun-sin In generators like gradient background suppose the user add a third color input box but fill only the first two color input boxes, then the background field in the css code remains null. Do i need to check for null value display a notification for that ?

Dun-sin commented 1 year ago

:tada: This PR is included in version 2.70.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: