Dun-sin / Code-Magic

Code Generator - Easily Generate CSS and Tailwind code based on your choice and input
https://code-magic.vercel.app
MIT License
382 stars 203 forks source link

[BUG] add a min and max for input number #510

Closed Dun-sin closed 10 months ago

Dun-sin commented 10 months ago

Description

In the input range generator, add a min & max number

min="1"
max="120"

in the input number for thumb and track radius https://github.com/Dun-sin/Code-Magic/blob/8d73ffd5778bcbcca9b11e7bedcb779f5212dc69/index.html#L1212-L1220 https://github.com/Dun-sin/Code-Magic/blob/8d73ffd5778bcbcca9b11e7bedcb779f5212dc69/index.html#L1237-L1245

Screenshots

No response

Additional information

No response

πŸ₯¦ Browser

Mozilla Firefox

πŸ‘€ Have you checked if this issue has been raised before?

🏒 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

None

github-actions[bot] commented 10 months ago

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

AfzalAnsariMd commented 10 months ago

Hey, I would like to work on this. Can you please assign this to me?

dhananjay-Byte commented 10 months ago

hey @Dun-sin I would like to work on this issue. will you please assign me this?

Dun-sin commented 10 months ago

hey @Dun-sin I would like to work on this issue. will you please assign me this?

Definitely, thanks for wanting to contribute, read the issue description properly and understand what it tells you to do also feel free to ask questions, make sure you follow the rules πŸ‘‰πŸ½hereπŸ‘ˆπŸ½, else your PR will not be accepted and will be closed. Good Luck.

Dun-sin commented 10 months ago

Hello @Dun-sin I would like to work on this issue. will you please assign me this issue ? i think its a quick work . we only need to do this if i am not wrong .

Screenshot 2023-10-19 233526

Don't waste your time, as you can see(hopefully) it's already assigned

dhananjay-Byte commented 10 months ago

@Dun-sin i suggest to change the text in placeholder into "Enter the number from 1 to 120" to tell the user about the range of input. should i change it?

Dun-sin commented 10 months ago

@Dun-sin i suggest to change the text in placeholder into "Enter the number from 1 to 120" to tell the user about the range of input. should i change it?

no, stick to your issue

dhananjay-Byte commented 10 months ago

got it.. what about responsiveness ? adding min and max attributes changing the width of the input field. it shrinks in size

Dun-sin commented 10 months ago

got it.. what about responsiveness ? adding min and max attributes changing the width of the input field. it shrinks in size

i don't understand you

dhananjay-Byte commented 10 months ago

this is the result after adding min and max attribute in input tag.

Screenshot (459)

Dun-sin commented 10 months ago

this is the result after adding min and max attribute in input tag.

Screenshot (459)

leave it, just create a PR, will handle that later

dhananjay-Byte commented 10 months ago

ok sure

Dun-sin commented 10 months ago

:tada: This issue has been resolved in version 2.75.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: