Dun-sin / Code-Magic

Code Generator - Easily Generate CSS and Tailwind code based on your choice and input
https://code-magic.vercel.app
MIT License
382 stars 203 forks source link

fix: made input range responsive in mobile view #520

Closed viditagrawal56 closed 10 months ago

viditagrawal56 commented 10 months ago

Fixes Issue

My PR closes #519

👨‍💻 Changes proposed(What did you do ?)

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

image

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-magic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 9:22am
viditagrawal56 commented 10 months ago

@Dun-sin when the screen size < 1000 px the width of the checkbox suddenly becomes half of the original width, and I can't find why it does that. Also you said that you don't see the issue on Firefox, but I faced this issue on Firefox too. So I just doubled the width of the checkbox in the media query of max-width 1000.

Let me know if you need any changes.

Dun-sin commented 10 months ago

your PR makes it worse on firefox: image

viditagrawal56 commented 10 months ago

@Dun-sin That's really weird. Because for me on Firefox it resolves the issue. I have attached Screen shots below.

Desktop view on Firefox :- image

Mobile view on Firefox :- image

viditagrawal56 commented 10 months ago

@Dun-sin Works even in the deployment preview

image

viditagrawal56 commented 10 months ago

@Dun-sin I found a new fix. I set the flex-shrink to 0 and it seems to fix the issue. Can you please check on your browser?

Dun-sin commented 10 months ago

@Dun-sin I found a new fix. I set the flex-shrink to 0 and it seems to fix the issue. Can you please check on your browser?

@viditagrawal56 it works now

Dun-sin commented 10 months ago

:tada: This PR is included in version 2.72.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: