Closed hanzalahwaheed closed 10 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
code-magic | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 21, 2023 5:07pm |
@Dun-sin I know that the Issue instructed us to add padding to just the Download Buttons. But here I have added them to the Get Code Buttons as well. Let me know if its alright or I will make changes.
@Dun-sin I know that the Issue instructed us to add padding to just the Download Buttons. But here I have added them to the Get Code Buttons as well. Let me know if its alright or I will make changes.
Stick to your issue, don't go outside of it. That's not appreciated.
@Dun-sin I know that the Issue instructed us to add padding to just the Download Buttons. But here I have added them to the Get Code Buttons as well. Let me know if its alright or I will make changes.
Stick to your issue, don't go outside of it. That's not appreciated.
Okay! Thanks for notifying!
So I only need the Download Buttons to have spacing in between them right?
Like this screenshot here:
I will change back the Copy Code Buttons to as before (no spacing).
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
@hanzalahwaheed fix this error, if you don't know how, try this:
Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged
Fixes Issue
My PR closes #506
👨💻 Changes proposed(What did you do ?)
I have added padding to all the drop-down buttons in the project.
✔️ Check List (Check all the applicable boxes)
Note to reviewers
📷 Screenshots