Dun-sin / Whisper

A fun Application to have a random chat with people safely

https://whisper.favour.dev/

MIT License

379 stars 342 forks source link

fix: scrollbar bug fixed #543

Closed Aryakoste closed 11 months ago

Aryakoste commented 11 months ago

Fixes Issue #536

**My PR closes #536

👨‍💻 Changes proposed(What did you do ?)

The fontsize of text inside the textarea was 18px + padding bottom(10px) + padding top(10px) it is 48 which is higher than its acutual height which is 45px so i increased it to 48px for the content to not overflow.
I set overflow auto to both chat input and chat container which will only show scrollbar when the content overflows the container which solves the problem.

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

vercel[bot] commented 11 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
whisper	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 1:23pm

Dun-sin commented 11 months ago

if you want to change it to 48px then you have to change it here too:

https://github.com/Dun-sin/Whisper/blob/dd0dc794c584a86c5325cd366b68d9d92547837b/client/src/components/Chat.jsx#L220C3-L220C34