Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
379 stars 342 forks source link

feat: changed the style of dropdown properly #556

Closed Roshanchau closed 11 months ago

Roshanchau commented 11 months ago

Fixes #523

My PR closes #issue_number_here

👨‍💻 Changes proposed(What did you do ?)

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

vercel[bot] commented 11 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Dun-sin commented 11 months ago

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:

* docs: correct typo in README

* feat: implement dark mode"

* fix: correct remove button behavior

Linting Errors

* Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"

* No subject found

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

* package-lock.json

@Roshanchau Please fix this error, if you don't know how, try this:

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

Roshanchau commented 11 months ago

I changed the commit message hope it is convenient to merge.

Dun-sin commented 11 months ago

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package-lock.json

@Roshanchau you are good to go when this error changes

Roshanchau commented 11 months ago

Is it done now ?

Roshanchau commented 11 months ago

do you mean the format changes in the code or something else i didn't get it.

Dun-sin commented 11 months ago

do you mean the format changes in the code or something else i didn't get it.

yes in the code

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
whisper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 7:19am
Roshanchau commented 11 months ago

I removed the format changes.