Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
379 stars 342 forks source link

fix #589 #588

Closed MJinH closed 8 months ago

MJinH commented 8 months ago

Fixes Issue

My PR closes #586

👨‍💻 Changes proposed(What did you do ?)

fixed the error where the chat wasn't displaying, and the issue where messages weren't being delivered when the other user sent. fixed name and type errors

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

chat_error

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Dun-sin commented 8 months ago

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@MJinH Please fix this error, if you don't know how, try this:

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

MJinH commented 8 months ago

actually, let me close this PR and create a new one.

Dun-sin commented 8 months ago

actually, let me close this PR and create a new one.

okay, but keep in mind my code review here, so you fix it on your new PR