search

Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
378 stars 342 forks source link

[FEATURE] Improve on `Chat` component size #593

Closed mathiasayivor closed 8 months ago

mathiasayivor commented 8 months ago

Description

The current Chat component imports bad words data statically here: https://github.com/Dun-sin/Whisper/blob/b73c6db38c94ebe052d8aaf512379a4a1401f4de/src/components/Chat.tsx#L18-L19C46

This impacts the component's size hence the loading time. It would be better to lazily load this data using dynamic imports for improved results

Screenshots

No response

Additional information

No response

👀 Have you checked if this issue has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

github-actions[bot] commented 8 months ago

This issue is waiting to be approved so it's locked until approved
Thank you @mathiasayivor for creating an issue, while you wait for a response, consider reading the Contributing.md file If you have any questions, please reach out to us on Discord or follow up on the issue itself. Welcome to the community!!

Log | Bot Usage
github-actions[bot] commented 8 months ago

This issue is ready for dev and assigned to anyone who properly asks

Log | Bot Usage
DevDaniloFerrari commented 8 months ago

Hello, I've begun working on addressing this issue, but I haven't completed it yet. Could you please assign this issue to me?

Dun-sin commented 8 months ago

Hello, I've begun working on addressing this issue, but I haven't completed it yet. Could you please assign this issue to me?

Go for it, but when you're making your PR take notes of the guidelines in the contributing.md