Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
390 stars 367 forks source link

[BUG] Dark Mode not working #597

Closed ABHID10 closed 5 months ago

ABHID10 commented 10 months ago

Description

Dark mode feature not working properly.

Screenshots

image Screenshot 2024-01-21 210122

Additional information

Nope

🥦 Browser

Google Chrome

👀 Have you checked if this issue has been raised before?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

github-actions[bot] commented 10 months ago

This issue is waiting to be approved so it's locked until approved
Thank you @ABHID10 for creating an issue, while you wait for a response, consider reading the Contributing.md file If you have any questions, please reach out to us on Discord or follow up on the issue itself. Welcome to the community!!

Log | Bot Usage
Dun-sin commented 10 months ago

Hi @ABHID10, thanks for wanting to contribute, you've got it assigned to you ask if you have questions on the discord server. Follow the guidelines here, or your PR won't be accepted and will be closed. Good luck!

github-actions[bot] commented 10 months ago

This issue is ready for dev and assigned to anyone who properly asks

Log | Bot Usage
RazaAbbas62 commented 10 months ago

Hi, Can i do this task , if not assigned to anyone?

Dun-sin commented 9 months ago

@ABHID10 how's this going?

ABHID10 commented 9 months ago

I have gone through the documentation to understand the codebase. I am doing the task on priority.

Dun-sin commented 9 months ago

I have gone through the documentation to understand the codebase. I am doing the task on priority.

It's a 7 days assigned issue which means the 7 days are up, but will give an extension of 3 days

ishn123 commented 9 months ago
Screenshot 2024-02-04 at 6 52 54 PM

Hi @Dun-sin I have fixed this issue in the existing code, Can I raise PR for that?

Dun-sin commented 9 months ago
Screenshot 2024-02-04 at 6 52 54 PM

Hi @Dun-sin I have fixed this issue in the existing code, Can I raise PR for that?

That doesn't fix the issue

ishn123 commented 9 months ago

@Dun-sin Could you please add the screenshots for what is the actual bug and what is expected.

Dun-sin commented 9 months ago

We already have dark mode implemented, but it's not working on toggle. That's why it's a bug to be fixed not a feature added

424

ishn123 commented 9 months ago

I haven't added any new feature, in the existing code only I have added few things, even haven't made any new variables.

Karan9927 commented 9 months ago

@Dun-sin Just wanted to give you a heads up that I've reviewed the issue and managed to solve it! I've also attached the images for your reference. Do let me know if i can make a pull request. image image

Dun-sin commented 9 months ago

@Dun-sin Just wanted to give you a heads up that I've reviewed the issue and managed to solve it! I've also attached the images for your reference. Do let me know if i can make a pull request. image image

Still not correct as the background color is missing, as I said this isn't a feature but a bug if you truly fixed it everything should fall into place, could be a problem with context or how it's read

Karan9927 commented 9 months ago

You want the white background of the form that is behind to be dark on toggle or the background color of the page to be dark on toggle be specific?

Dun-sin commented 9 months ago

You want the white background of the form that is behind to be dark on toggle or the background color of the page to be dark on toggle be specific?

Everything was already set up, the toggle just isn't working, all this issue is saying is, fix the toggle and make it work

Karan9927 commented 9 months ago

I Made it work like you wanted and shared the screenshot I can make a PR in that you can view the changes and review the code.

ishn123 commented 9 months ago

@Dun-sin I have made it work like you are mentioning.

Dun-sin commented 9 months ago

@ishn123 @Karan9927 none of you have showed me the right thing, and right now I'm too busy to be going back and forth with this, so will just fix it myself when I have the time.

Thanks for wanting to help, if you want to communicate more on this then join the discord server and we can talk there, as for now will be locking this.

And for the love of God @Karan9927 stop creating unnecessary issues