search

Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
390 stars 367 forks source link

[FEATURE] move menu toggle into it's own component #660

Closed Dun-sin closed 2 months ago

Dun-sin commented 3 months ago

Description

For cleaner code, move this to its own component and call it in Anonymous.jsx component

https://github.com/Dun-sin/Whisper/blob/dbec99c68f63c606647ea2cef1d458a72ae83b1b/client/src/components/Anonymous.jsx#L153-L163

Additional Information

Provide a screen recording of the menu toggle working

github-actions[bot] commented 3 months ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

Bridgetamana commented 3 months ago

I can do this

Priyanshu-2005 commented 3 months ago

Hey @Dun-sin I want to work on this issue kindly assign it to me.

Dun-sin commented 3 months ago

sorry @Priyanshu-2005 @Bridgetamana asked first, but @Priyanshu-2005 you can go through other good first issues and indicate there instead

Dun-sin commented 3 months ago

I can do this

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

Dun-sin commented 2 months ago

@Priyanshu-2005 are you still up for this?

Priyanshu-2005 commented 2 months ago

@Dun-sin Yes i am willing to contribute Kindly assign this issue to me.

Dun-sin commented 2 months ago

@Dun-sin Yes i am willing to contribute Kindly assign this issue to me.

alright then, Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!