Dun-sin / Whisper

A fun Application to have a random chat with people safely
https://whisper.favour.dev/
MIT License
390 stars 367 forks source link

refactor: move reconnect banner to a new component #691

Closed LuseBiswas closed 2 months ago

LuseBiswas commented 2 months ago

Fixes Issue

My PR closes #662

👨‍💻 Changes proposed(I had made another component inside component 📁 named as ReconnectBanner.jsx and import it in BuddyMatcher.jsx)

✔️ Check List (Check all the applicable boxes)

Note to reviewers

📷 Screenshots

vercel[bot] commented 2 months ago

@LuseBiswas is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

LuseBiswas commented 2 months ago

@Dun-sin I think Now I had complete the Compilance/PR Checks . I had setup the code locally before, but due to the issue I had to delete it. But my codes work fine. You can check at your own to. Hope it get merged soon.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
whisper-b2p2 ❌ Failed (Inspect) Sep 6, 2024 10:51am
Dun-sin commented 2 months ago

@Dun-sin I think Now I had complete the Compilance/PR Checks . I had setup the code locally before, but due to the issue I had to delete it. But my codes work fine. You can check at your own to. Hope it get merged soon.

If you can't test it locally, you can use the preview link from vercel right here in the PR and attach the screen recording

Dun-sin commented 2 months ago

@LuseBiswas you also need to remove the package.json file from your PR, don't delete it, remove it. There's a difference please

Dun-sin commented 2 months ago

@LuseBiswas looks like your build fails