DuneSt / MaterialDesignLite

This project prime goal is to bind the google's Material Design Lite project to Seaside and as second goal to build widgets on top of Material Design to help Seaside developers to create web applications with material design faster.
https://mdl.ferlicot.fr/
MIT License
40 stars 20 forks source link

Refactore-expansion-panel #284

Closed jecisc closed 4 years ago

jecisc commented 4 years ago

In this PR I refactore some part of the expansion panel:

Fixes #269 Fixes #280

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 590


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Material-Design-Lite-Widgets/MDLHideExpansionStrategy.class.st 0 5 0.0%
src/Material-Design-Lite-Widgets/MDLLazyExpansionStrategy.class.st 0 8 0.0%
src/Material-Design-Lite-Widgets/MDLAjaxExpansionStrategy.class.st 0 9 0.0%
src/Material-Design-Lite-Widgets/MDLExpansionPanel.class.st 3 19 15.79%
<!-- Total: 16 54 29.63% -->
Files with Coverage Reduction New Missed Lines %
src/Material-Design-Lite-Widgets/MDLLazyExpansionStrategy.class.st 1 23.53%
src/Material-Design-Lite-Widgets/MDLAjaxExpansionStrategy.class.st 2 0.0%
src/Material-Design-Lite-Widgets/MDLExpansionPanel.class.st 4 54.44%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 587: 0.03%
Covered Lines: 3298
Relevant Lines: 5000

💛 - Coveralls
jecisc commented 4 years ago

Here is the example of the brush demo:

2019-10-26_19-16-55

Here is the example of the widget demo 2019-10-26_19-17-32

juliendelplanque commented 4 years ago

Maybe the rotation speed for the animation should be a little faster?

jecisc commented 4 years ago

I updated animations from 0.5sec to 0.3sec.